Add bmp dynamic feature switch in frr side config. #20895
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
FengPan-Frank
force-pushed
the
frr_bmp_config
branch
from
c0ab71a
to
653788d
Compare
FengPan-Frank
force-pushed
the
frr_bmp_config
branch
from
653788d
to
5239344
Compare
|
Hi @StormLiangMS , we have new feature "bmp" which would like to be enabled in runtime later per NDM liquid config. The feature requires frr side config + cmd change, could you help on review if there's any concern? Thanks |
qiluo-msft
reviewed
Nov 22, 2024
qiluo-msft
approved these changes
Nov 23, 2024
|
/azpw ms_conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add bmp dynamic feature switch in frr side config, later will update liquid template to control bmp feature based on version.
Work item tracking
How I did it
Update bgpd.conf and supervisord.conf template to monitor the feature switch, and turn on corresponding section. Later once we want to turn on bmp feature, we will assign specific version on NDM liquid template, and on the rollout-ed host it will require a new config reload to take effect.
How to verify it
Added unit test cases.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)